Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some build modifications #46

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Some build modifications #46

merged 4 commits into from
Oct 10, 2023

Conversation

philipnbbc
Copy link
Collaborator

This PR

  • adds an action to build a MacOS Universal Binary using XCode
  • Defaults to position independent code, whether building shared or static libraries
  • Changes the *_SET_MSVC_RUNTIME option to be a string with value "MD" (MultiThreadedDLL) "MT" (MultiThreaded) or "default" (the CMAKE default, which is "MD"). The "d" for debug is added automatically.

@philipnbbc
Add action to build and test XCode universal binaries
af1708c
@philipnbbc
Default build with CMAKE_POSITION_INDEPENDENT_CODE=ON
faedc7a 
not just for shared library builds. This allows static bmx
libraries to be linked into other shared libraries.

If CMAKE_POSITION_INDEPENDENT_CODE is already defined then leave
it as-is.
@philipnbbc
Change *_SET_MSVC_RUNTIME to string option and support MT
2810e55 
Set to "MT" to use MultiThreaded, "MD" for MultiThreadedDLL and
"default" for cmakes default.
@philipnbbc
Use POLICY value rather than cmake version to decide setting runtime
e8c34ec
@philipnbbc philipnbbc merged commit d1ff8de into main Oct 10, 2023
10 checks passed
@philipnbbc philipnbbc deleted the philipn-build-mods branch October 10, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philipnbbc